PetitbootConfig: Update configuration tests #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of configuration-related tests were waiting for NVRAM support and a reliable network address in Qemu. Now that we have it, update these tests so that a) they run at all, b) they reflect current Petitboot behaviour, and c) try to preserve the state of NVRAM before the test. This has also had autopep8 run against it so bring it in to line with other work. Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
|
retest this please |
PraveenPenguin
force-pushed
the
master
branch
2 times, most recently
from
4d0cb14
to
b976629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of configuration-related tests were waiting for NVRAM support
and a reliable network address in Qemu. Now that we have it, update
these tests so that
a) they run at all,
b) they reflect current Petitboot behaviour, and
c) try to preserve the state of NVRAM before the test.
This has also had autopep8 run against it so bring it in to line with
other work.
Signed-off-by: Samuel Mendoza-Jonas sam@mendozajonas.com