Check if the Host is powered off before probing the console #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we spend time trying to detect what system the state is in by writing to the host console we should check if the host is powered on or not. I don't think I've seen a BMC give a false-off so this should be reliable and save a bit of time on the probing. This isn't critical for CI runs, but it's nice when using op-test manually from the command line. Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
hegdevasant
approved these changes
Feb 20, 2020
PraveenPenguin
force-pushed
the
master
branch
2 times, most recently
from
4d0cb14
to
b976629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we spend time trying to detect what system the state is in by
writing to the host console we should check if the host is powered on
or not.
I don't think I've seen a BMC give a false-off so this should be
reliable and save a bit of time on the probing. This isn't critical for
CI runs, but it's nice when using op-test manually from the command
line.
Signed-off-by: Oliver O'Halloran oohall@gmail.com