Add grubby to handle latest grub2 changes #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdhaleegit
force-pushed
the
grubby-fix
branch
from
a142cf4
to
7d8bca8
Compare
sacsant
reviewed
Nov 23, 2023
testcases/InstallUpstreamKernel.py
Outdated
| @@ -128,8 +128,7 @@ def is_url(path): | |||
| time.sleep(10) | |||
| if not self.use_kexec: | |||
| # FIXME: Handle distributions which do not support grub | |||
| con.run_command( | |||
| "grub2-mkconfig --output=/boot/grub2/grub.cfg") | |||
| con.run_command("grubby --set-default /boot/vmlinuz-%s" % res[-1]) | |||
There was a problem hiding this comment.
We will need code to handle vmlinux vs vmlinuz. Additionally we should also handle different distro flavours.
There was a problem hiding this comment.
@abdhaleegit can you please address sachin's review comment and we able to conclude these changes
There was a problem hiding this comment.
yes I have the code ready
abdhaleegit
force-pushed
the
grubby-fix
branch
2 times, most recently
from
ec66819
to
2cc7254
Compare
abdhaleegit
force-pushed
the
grubby-fix
branch
2 times, most recently
from
da9d12c
to
9da58c2
Compare
abdhaleegit
force-pushed
the
grubby-fix
branch
from
c17b2d0
to
e195d47
Compare
| @@ -1475,12 +1475,12 @@ def get_login(self, host, term_obj, pty, prompt): | |||
| my_user = host.username() | |||
| my_pwd = host.password() | |||
| pty.sendline() | |||
| rc = pty.expect(['login: ', pexpect.TIMEOUT, pexpect.EOF], timeout=10) | |||
| rc = pty.expect(['login: ', pexpect.TIMEOUT, pexpect.EOF], timeout=60) | |||
There was a problem hiding this comment.
can we have this as class/function variable? so changing one place is easy in future as well
abdhaleegit
force-pushed
the
grubby-fix
branch
2 times, most recently
from
e738300
to
29694da
Compare
With latest grub2 installer, one should set the kernel to be booted explicitly after update or install of latest kernel Signed-off-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
When LPAR is loaded with devices and adpater and network load is high, the console, boot and prompt response is slow so increase wait time to handle these Signed-off-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
abdhaleegit
force-pushed
the
grubby-fix
branch
2 times, most recently
from
e2505f2
to
f9e4dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With latest grub2 installer, one should set the
kernel to be booted explicitly after update or
install of latest kernel