Skip to content

Commit

Permalink
p9_sbe_tp_switch_gears, p9_sbe_gear_switcher: Level 3
Browse files Browse the repository at this point in the history 
Change-Id: Ie0bef712a4053eef0022b4f01c3cda9c3c3c8aba
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38795
Reviewed-by: Joachim Fenkes <fenkes@de.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: RAJA DAS <rajadas2@in.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38797
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
  • Loading branch information
@fenkes-ibm @sgupta2m
fenkes-ibm authored and sgupta2m committed Jun 1, 2017
1 parent cddea03 commit 8355b24
Show file tree
Hide file tree
Showing 6 changed files with 108 additions and 30 deletions.
10 changes: 7 additions & 3 deletions src/import/chips/p9/procedures/hwp/perv/p9_sbe_gear_switcher.C
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
// *HWP HW Backup Owner : Srinivas V Naga <srinivan@in.ibm.com>
// *HWP FW Owner : sunil kumar <skumar8j@in.ibm.com>
// *HWP Team : Perv
// *HWP Level : 2
// *HWP Level : 3
// *HWP Consumed by : SBE
//------------------------------------------------------------------------------

Expand Down Expand Up @@ -138,8 +138,12 @@ fapi2::ReturnCode p9_sbe_gear_switcher_i2c_stop_sequence(
FAPI_INF("Loop Count :%d", l_timeout);

FAPI_ASSERT(l_timeout > 0,
fapi2::BUS_STATUS_BUSY_0(),
"ERROR:BUS_STSTUS_BUSY_0 NOT SET TO 0");
fapi2::BUS_STATUS_BUSY_0()
.set_TARGET_CHIP(i_target_chip)
.set_STATUS_REGISTER_B(l_data64)
.set_LOOP_COUNT(BUS_STATUS_BUSY_POLL_COUNT)
.set_BACKUP_SEEPROM_ATTR(l_read_attr),
"ERROR:BUS_STATUS_BUSY_0 NOT SET TO 0");

FAPI_DBG("Exiting ...");

Expand Down
4 changes: 2 additions & 2 deletions src/import/chips/p9/procedures/hwp/perv/p9_sbe_gear_switcher.H
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER sbe Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2015,2016 */
/* Contributors Listed Below - COPYRIGHT 2015,2017 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand All @@ -32,7 +32,7 @@
// *HWP HW Backup Owner : Srinivas V Naga <srinivan@in.ibm.com>
// *HWP FW Owner : sunil kumar <skumar8j@in.ibm.com>
// *HWP Team : Perv
// *HWP Level : 2
// *HWP Level : 3
// *HWP Consumed by : SBE
//------------------------------------------------------------------------------

Expand Down
5 changes: 3 additions & 2 deletions src/import/chips/p9/procedures/hwp/perv/p9_sbe_tp_switch_gears.C
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// *HWP HW Backup Owner : Srinivas V Naga <srinivan@in.ibm.com>
// *HWP FW Owner : sunil kumar <skumarj8@in.ibm.com>
// *HWP Team : Perv
// *HWP Level : 2
// *HWP Level : 3
// *HWP Consumed by : SBE
//------------------------------------------------------------------------------

Expand Down Expand Up @@ -158,7 +158,8 @@ fapi2::ReturnCode p9_sbe_tp_switch_gears_check_magicnumber(
fapi2::I2C_BUS_STATUS_BUSY()
.set_MASTER_CHIP(i_target_chip)
.set_STATUS_REGISTER_B(l_data64)
.set_LOOP_COUNT(l_timeout),
.set_LOOP_COUNT(BUS_STATUS_BUSY_POLL_COUNT)
.set_BACKUP_SEEPROM_ATTR(l_read_attr),
"ERROR:BUS_STSTUS_BUSY_0 NOT SET TO 0");

FAPI_DBG("Reading the value of DATA0TO7_REGISTER_B");
Expand Down
4 changes: 2 additions & 2 deletions src/import/chips/p9/procedures/hwp/perv/p9_sbe_tp_switch_gears.H
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER sbe Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2015,2016 */
/* Contributors Listed Below - COPYRIGHT 2015,2017 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand All @@ -31,7 +31,7 @@
// *HWP HW Backup Owner : Srinivas V Naga <srinivan@in.ibm.com>
// *HWP FW Owner : sunil kumar <skumarj8@in.ibm.com>
// *HWP Team : Perv
// *HWP Level : 2
// *HWP Level : 3
// *HWP Consumed by : SBE
//------------------------------------------------------------------------------

Expand Down
40 changes: 38 additions & 2 deletions src/import/chips/p9/procedures/xml/error_info/p9_sbe_gear_switcher_errors.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<!-- -->
<!-- OpenPOWER sbe Project -->
<!-- -->
<!-- Contributors Listed Below - COPYRIGHT 2015,2016 -->
<!-- Contributors Listed Below - COPYRIGHT 2015,2017 -->
<!-- [+] International Business Machines Corp. -->
<!-- -->
<!-- -->
Expand All @@ -31,7 +31,43 @@
<hwpError>
<sbeError/>
<rc>RC_BUS_STATUS_BUSY_0</rc>
<description>Status busy check</description>
<description>I2C stop sequence did not complete within timeout after switching SBE to PLL speed</description>
<collectRegisterFfdc>
<id>ROOT_CTRL_REGISTERS</id>
<target>TARGET_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>PERV_CTRL_REGISTERS</id>
<target>TARGET_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>I2C_REGISTERS</id>
<target>TARGET_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<ffdc>TARGET_CHIP</ffdc>
<ffdc>STATUS_REGISTER_B</ffdc>
<ffdc>LOOP_COUNT</ffdc>
<ffdc>BACKUP_SEEPROM_ATTR</ffdc>
<callout>
<procedure>CODE</procedure>
<priority>HIGH</priority>
</callout>
<callout>
<hw>
<hwid>SBE_SEEPROM_PART</hwid>
<refTarget>TARGET_CHIP</refTarget>
</hw>
<priority>MEDIUM</priority>
</callout>
<!--
not deconfiguring or garding anything here;
HWSV will have special handling for the SBE_SEEPROM_PART callout
that will first attempt to boot from the backup SEEPROM and gard
the chip if that fails.
-->
</hwpError>
<!-- ******************************************************************** -->
</hwpErrors>
75 changes: 56 additions & 19 deletions src/import/chips/p9/procedures/xml/error_info/p9_sbe_tp_switch_gears_errors.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<!-- -->
<!-- OpenPOWER sbe Project -->
<!-- -->
<!-- Contributors Listed Below - COPYRIGHT 2016 -->
<!-- Contributors Listed Below - COPYRIGHT 2016,2017 -->
<!-- [+] International Business Machines Corp. -->
<!-- -->
<!-- -->
Expand Down Expand Up @@ -34,22 +34,41 @@
<rc>RC_I2C_BUS_STATUS_BUSY</rc>
<description>I2C seeprom port is not responding</description>
<collectRegisterFfdc>
<id>ROOT_CTRL_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<id>ROOT_CTRL_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>PERV_CTRL_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<id>PERV_CTRL_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>I2C_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<id>I2C_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<ffdc>MASTER_CHIP</ffdc>
<ffdc>STATUS_REGISTER_B</ffdc>
<ffdc>LOOP_COUNT</ffdc>
<ffdc>BACKUP_SEEPROM_ATTR</ffdc>
<callout>
<hw>
<hwid>SBE_SEEPROM_PART</hwid>
<refTarget>MASTER_CHIP</refTarget>
</hw>
<priority>HIGH</priority>
</callout>
<callout>
<target>MASTER_CHIP</target>
<priority>MEDIUM</priority>
</callout>
<!--
not deconfiguring or garding anything here;
HWSV will have special handling for the SBE_SEEPROM_PART callout
that will first attempt to boot from the backup SEEPROM and gard
the chip if that fails.
-->
</hwpError>
<!-- ******************************************************************** -->
<hwpError>
Expand All @@ -59,23 +78,41 @@
read with Fused number in OTPROM
</description>
<collectRegisterFfdc>
<id>ROOT_CTRL_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<id>ROOT_CTRL_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>PERV_CTRL_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<id>PERV_CTRL_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>I2C_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<id>I2C_REGISTERS</id>
<target>MASTER_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<ffdc>MASTER_CHIP</ffdc>
<ffdc>DATA0TO7_REGISTER_B</ffdc>
<ffdc>MAGIC_NUMBER_VALUE</ffdc>
<ffdc>BACKUP_SEEPROM_ATTR</ffdc>
<callout>
<hw>
<hwid>SBE_SEEPROM_PART</hwid>
<refTarget>MASTER_CHIP</refTarget>
</hw>
<priority>HIGH</priority>
</callout>
<callout>
<target>MASTER_CHIP</target>
<priority>MEDIUM</priority>
</callout>
<!--
not deconfiguring or garding anything here;
HWSV will have special handling for the SBE_SEEPROM_PART callout
that will first attempt to boot from the backup SEEPROM and gard
the chip if that fails.
-->
</hwpError>
<!-- ******************************************************************** -->
</hwpErrors>

0 comments on commit 8355b24

Please sign in to comment.