Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confignet] Should TransportType unmarshal be case insensitive? #10032

Open
TylerHelmuth opened this issue Apr 25, 2024 · 3 comments
Open

[confignet] Should TransportType unmarshal be case insensitive? #10032

TylerHelmuth opened this issue Apr 25, 2024 · 3 comments
Labels
area:config enhancement New feature or request priority:p2 Medium

Comments

@TylerHelmuth
Copy link
Member

Is your feature request related to a problem? Please describe.
Came across a situation in Contrib where the TransportType could not be used because the exporter supported tcp or TCP, but the TransportType unmarshal expects lowercase only.

open-telemetry/opentelemetry-collector-contrib#32379 (comment)

Describe the solution you'd like
Should we consider treating the strings we're unmarshalling as case insensitive?

@mx-psi
Copy link
Member

mx-psi commented Apr 30, 2024

We can do this after 1.0, right? As long as the error message is clear, I don't think there is a need to do this right now

@TylerHelmuth
Copy link
Member Author

I think it could wait until after 1.0 according to our version controls:

Relaxing validation rules. An invalid configuration struct as defined by its Validate method return value may become valid after a change to the validation rules.

@mx-psi
Copy link
Member

mx-psi commented May 2, 2024

Oki, I am going to remove from the 1.0 milestone then (we can still do it now, just want to make it clear this is not a blocker for 1.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config enhancement New feature or request priority:p2 Medium
Projects
None yet
Development

No branches or pull requests

2 participants