[exporter/syslog][chore] use consts for network protocol names #32379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
approved these changes
Apr 15, 2024
andrzej-stencel
approved these changes
Apr 15, 2024
rnishtala-sumo
approved these changes
Apr 15, 2024
codeboten
reviewed
Apr 15, 2024
kkujawa-sumo
force-pushed
the
kkujawa_change_tcp_udp_strings
branch
from
d6caceb
to
b6152f9
Compare
andrzej-stencel
approved these changes
Apr 20, 2024
|
Please handle merge conflicts |
kkujawa-sumo
force-pushed
the
kkujawa_change_tcp_udp_strings
branch
from
b6152f9
to
9200a77
Compare
|
@TylerHelmuth conflicts resolved |
codeboten
approved these changes
Apr 30, 2024
TylerHelmuth
approved these changes
May 1, 2024
TylerHelmuth
added
the
ready to merge
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…telemetry#32379) use consts for network protocol names, changes were suggested in open-telemetry#31202 (comment) **Testing:** unit tests, manual tests with syslog server --------- Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: [exporter/syslog][chore] use consts for network protocol names, changes were suggested in #31202 (comment)
Link to tracking Issue: #31130
Testing: unit tests, manual tests with syslog server