[Draft] Add check for local changes in obs-api package using rpm #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a playbook that will fail the deployment if there are local changes to the package obs-api. The verification is done via rpm and in my tests the changes are printed if the shell command has non zero return code. Requires a bool (overwrite_local_changes, default to false) to switch mode in case the local changes need to be overwritten. Since I cannot fully test, for this draft I'm adding the include just in deploy_without_migration.yml for completion.
danidoni
reviewed
Dec 2, 2022
| ignore_errors: false | ||
| become: true | ||
| when: | ||
| - not overwrite_local_changes |
There was a problem hiding this comment.
If I understand it correctly, this flag is not preventing overwrites but preventing the execution of the task, right?
There was a problem hiding this comment.
Maybe we can improve the naming a bit, if this, in fact, is not overwriting the local changes :)
There was a problem hiding this comment.
What about "skip_local_rpm_check"?
There was a problem hiding this comment.
@guxtavo Do you need some help with this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a playbook that will fail the deployment if there are local changes to the package obs-api. The verification is done via rpm and in my tests the changes are printed if the shell command has non zero return code.
Requires a bool (overwrite_local_changes, default to false) to switch mode in case the local changes need to be overwritten.
Since I cannot fully test, for this draft I'm adding the include just in deploy_without_migration.yml for completion.