Prefer Kernel::format over sprintf

openSUSE · Mar 15, 2024 · a1a3486 · a1a3486
1 parent 27ada67
commit a1a3486
Showing 1 changed file with 15 additions and 15 deletions.
diff --git a/src/api/app/components/bs_request_action_description_component.rb b/src/api/app/components/bs_request_action_description_component.rb
@@ -6,14 +6,14 @@ class BsRequestActionDescriptionComponent < ApplicationComponent
   delegate :project_or_package_link, to: :helpers
 
   DESCRIPTION_TEMPLATE = {
-    'submit' => 'Submit %{source_container} to %{target_container}',
-    'delete' => 'Delete %{target_repository}%{target_container}',
-    'add_role' => '%{creator} wants %{requester} to %{task} for %{target_container}',
-    'set_bugowner' => '%{creator} wants %{requester} to %{task} for %{target_container}',
-    'change_devel' => 'Set %{source_container} to be devel project/package of %{target_container}',
-    'maintenance_incident' => 'Submit update from %{source_container} to %{target_container}',
-    'maintenance_release' => 'Maintenance release %{source_container} to %{target_container}',
-    'release' => 'Release %{source_container} to %{target_container}'
+    'submit' => 'Submit %<source_container>s to %<target_container>s',
+    'delete' => 'Delete %<target_repository>s%<target_container>s',
+    'add_role' => '%<creator>s wants %<requester>s to %<task>s for %<target_container>s',
+    'set_bugowner' => '%<creator>s wants %<requester>s to %<task>s for %<target_container>s',
+    'change_devel' => 'Set %<source_container>s to be devel project/package of %<target_container>s',
+    'maintenance_incident' => 'Submit update from %<source_container>s to %<target_container>s',
+    'maintenance_release' => 'Maintenance release %<source_container>s to %<target_container>s',
+    'release' => 'Release %<source_container>s to %<target_container>s'
   }.freeze
 
   # rubocop:disable ViewComponent/AvoidGlobalState
@@ -33,17 +33,17 @@ def description
 
     description = case action.type
                   when 'submit', 'change_devel', 'maintenance_incident', 'maintenance_release', 'release'
-                    sprintf(DESCRIPTION_TEMPLATE[action.type], source_container: source_container, target_container: target_container)
+                    Kernel::format(DESCRIPTION_TEMPLATE[action.type], source_container: source_container, target_container: target_container)
                   when 'delete'
                     target_repository = "repository #{link_to(action.target_repository, repositories_path(target_project_hash))} for " if action.target_repository
 
-                    sprintf(DESCRIPTION_TEMPLATE[action.type], target_repository: target_repository, target_container: target_container)
+                    Kernel::format(DESCRIPTION_TEMPLATE[action.type], target_repository: target_repository, target_container: target_container)
                   when 'add_role', 'set_bugowner'
-                    sprintf(DESCRIPTION_TEMPLATE[action.type],
-                            creator: user_with_realname_and_icon(creator),
-                            requester: requester_str(creator, action.person_name, action.group_name),
-                            task: creator_intentions(action.role),
-                            target_container: target_container)
+                    Kernel::format(DESCRIPTION_TEMPLATE[action.type],
+                           creator: user_with_realname_and_icon(creator),
+                           requester: requester_str(creator, action.person_name, action.group_name),
+                           task: creator_intentions(action.role),
+                           target_container: target_container)
                   else
                     ''
                   end