Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations reminder #15423

Closed
wants to merge 3 commits into from
Closed

Conversation

saraycp
Copy link
Contributor

@saraycp saraycp commented Dec 28, 2023

Instead of having a GitHub check that needs to pass, we better have a comment in the PR as a reminder.
The purpose is to warn that the migrations and related code changes should be shipped separately. We don't need to complicate things much.

@github-actions github-actions bot added Frontend Things related to the OBS RoR app Test Suite / CI 💉 Things related to our tests/CI labels Dec 28, 2023
@saraycp saraycp force-pushed the migrations_reminder branch 2 times, most recently from 93d5465 to eca6c1a Compare December 28, 2023 15:58
@saraycp saraycp force-pushed the migrations_reminder branch 7 times, most recently from 734a349 to 5d6e4de Compare December 29, 2023 12:24
@danidoni
Copy link
Contributor

danidoni commented Jan 3, 2024

Could be that you need to run the migrations locally and upload the new schema file?

@saraycp
Copy link
Contributor Author

saraycp commented Jan 3, 2024

Could be that you need to run the migrations locally and upload the new schema file?

The check "Migrations Reminder" is failing due to permissions stuff. The exact same GitHub action works in another repo I have for testing. But it doesn't work in this repository. Still trying to figure out...

@saraycp
Copy link
Contributor Author

saraycp commented Mar 19, 2024

This is already covered in #15824

@saraycp saraycp closed this Mar 19, 2024
@saraycp saraycp deleted the migrations_reminder branch March 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app Test Suite / CI 💉 Things related to our tests/CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants