Move view_file into files controller #15766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellcp-work
force-pushed
the
files-controller-p3
branch
8 times, most recently
from
1202320
to
66fc82e
Compare
hellcp-work
force-pushed
the
files-controller-p3
branch
from
66fc82e
to
faf4056
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15766 +/- ##
==========================================
+ Coverage 86.10% 86.13% +0.03%
==========================================
Files 793 793
Lines 26024 26023 -1
==========================================
+ Hits 22407 22415 +8
+ Misses 3617 3608 -9 |
danidoni
reviewed
Mar 15, 2024
| @@ -25,6 +25,3 @@ | |||
| = link_to 'Repository State', project_package_repository_binaries_path(@project, @package_name, @repository) | |||
| %li.breadcrumb-item.active{ 'aria-current' => 'page' } | |||
| Statistics | |||
| - if current_page?(package_view_file_path(@project, @package)) | |||
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm sorry but I don't see the same code in there...
There was a problem hiding this comment.
current_page?(package_view_file_path(@project, @package)) is equivalent to action_name == 'show' in the context of the new controller
danidoni
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #15754