Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing diff_limit variable #15797

Merged

Conversation

danidoni
Copy link
Contributor

It's not set in Webui::RequestController#build_results, so it's getting nil all the way down.

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Mar 14, 2024
@danidoni danidoni force-pushed the removing-diff-limit-instance-variable branch from 21704e3 to b4ecd5d Compare March 14, 2024 15:54
It's not set in Webui::RequestController#build_results, so it's getting nil all the
way down.
@danidoni danidoni force-pushed the removing-diff-limit-instance-variable branch from b4ecd5d to f4c24a0 Compare March 15, 2024 09:40
Copy link
Contributor

@ncounter ncounter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, JFYI I am addressing this already and widely in #15794 at the commit 02a31af

@danidoni danidoni merged commit 14ba4b7 into openSUSE:master Mar 15, 2024
19 checks passed
@danidoni danidoni deleted the removing-diff-limit-instance-variable branch March 15, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app Refactoring 🏭
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants