Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor branch package step spec #15801

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Refactor branch package step spec #15801

merged 7 commits into from
Mar 15, 2024

Commits on Mar 14, 2024

  1. Test #validate_required_keys_in_step_instructions 

    Once in Step spec.
    @hennevogel
    hennevogel committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    efcb049 View commit details
    Browse the repository at this point in the history

  2. Test BranchPackageStep.check_source_access logic once 

    No need to test the same logic 5 times...
    @hennevogel
    hennevogel committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    86f86f4 View commit details
    Browse the repository at this point in the history

  3. Test create_branched_package rescue logic once 

    Not 4 times...
    @hennevogel
    hennevogel committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    558932d View commit details
    Browse the repository at this point in the history

  4. Test skip_repositories? once 

    No need to test the same logic 3 times...
    @hennevogel
    hennevogel committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    290a300 View commit details
    Browse the repository at this point in the history

  5. Remove singular use shared context

    @hennevogel
    hennevogel committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a4c1187 View commit details
    Browse the repository at this point in the history

  6. Remove singular use shared context

    @hennevogel
    hennevogel committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    e22bdcc View commit details
    Browse the repository at this point in the history

  7. Adapt cassettes to BranchPackageStep spec

    @hennevogel
    hennevogel committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    5fdc82e View commit details
    Browse the repository at this point in the history