Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring LinkPackageStep spec #15853

Merged
merged 6 commits into from Mar 21, 2024
Merged

Refactoring LinkPackageStep spec #15853

merged 6 commits into from Mar 21, 2024

Commits on Mar 21, 2024

  1. Do not test Step#target_project_name again 

    It's tested in Step spec
    @hennevogel
    hennevogel committed Mar 21, 2024
    Copy the full SHA
    e08b428 View commit details
    Browse the repository at this point in the history

  2. Move test data creation to the outermost context 

    Instead of repeating it many times...
    @hennevogel
    hennevogel committed Mar 21, 2024
    Copy the full SHA
    b2b14f9 View commit details
    Browse the repository at this point in the history

  3. There is no reporting in steps 

    No need to test that it does not happen...
    @hennevogel
    hennevogel committed Mar 21, 2024
    Copy the full SHA
    15497f7 View commit details
    Browse the repository at this point in the history

  4. Stop SCMWebhook event specific testing 

    This steps behaves exactly the same no matter which event it gets.
No need to test everything 3 times...
    @hennevogel
    hennevogel committed Mar 21, 2024
    Copy the full SHA
    17e2b2a View commit details
    Browse the repository at this point in the history

  5. Remove shared contexts 

    Without not needed SCM webhook event specific testing, we don't
need shared contexts anymore...
    @hennevogel
    hennevogel committed Mar 21, 2024
    Copy the full SHA
    b2de7cb View commit details
    Browse the repository at this point in the history

  6. Adapt cassettes to LinkPackageStep spec

    @hennevogel
    hennevogel committed Mar 21, 2024
    Copy the full SHA
    14bffb3 View commit details
    Browse the repository at this point in the history