Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display link to staging project in conversation #15860

Merged
merged 1 commit into from Mar 22, 2024

Conversation

saraycp
Copy link
Contributor

@saraycp saraycp commented Mar 22, 2024

When the request has a review by project and that project is a staging one, we display a link to it instead of plain text.

Screenshot 2024-03-22 at 09-38-04 Open Build Service

Test with this review-app link: https://obs-reviewlab.opensuse.org/saraycp-staging_project_link/request/show/2
Or do:

  • Join beta request redesign
  • Add review
  • Choose review by project
  • Which project? A project which is a staging project already
  • You'll see the new link in the conversation

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.08%. Comparing base (47aaaea) to head (9c6ff2e).
Report is 3 commits behind head on master.

❗ Current head 9c6ff2e differs from pull request most recent head 5a671c0. Consider uploading reports for the commit 5a671c0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15860      +/-   ##
==========================================
- Coverage   86.09%   86.08%   -0.01%     
==========================================
  Files         794      794              
  Lines       26032    26024       -8     
==========================================
- Hits        22411    22403       -8     
  Misses       3621     3621              

@saraycp saraycp added the review-app Apply this label if you want a review app started label Mar 22, 2024
@obs-bot
Copy link
Collaborator

obs-bot commented Mar 22, 2024

Review app will appear here: http://obs-reviewlab.opensuse.org/saraycp-staging_project_link

When the request has a review by project and that project is a staging
one, we display a link to it instead of plain text.
@danidoni danidoni merged commit eb178fe into openSUSE:master Mar 22, 2024
20 checks passed
@danidoni danidoni deleted the staging_project_link branch March 22, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants