Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation of Socket.gethostbyname #15884

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 1 addition & 7 deletions .rubocop_todo.yml
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
# on 2024-03-04 14:13:59 UTC using RuboCop version 1.61.0.
# on 2024-03-26 08:59:27 UTC using RuboCop version 1.62.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -24,12 +24,6 @@ Lint/AssignmentInCondition:
Exclude:
- 'dist/clouduploader.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Lint/DeprecatedClassMethods:
Exclude:
- 'dist/t/spec/support/capybara.rb'

# Offense count: 2
Lint/RescueException:
Exclude:
Expand Down
2 changes: 1 addition & 1 deletion dist/t/spec/support/capybara.rb
Expand Up @@ -24,7 +24,7 @@

# Set hostname
begin
hostname = Socket.gethostbyname(Socket.gethostname).first
hostname = Addrinfo.getaddrinfo(Socket.gethostname, 443, nil, :STREAM).first.getnameinfo[0]
rescue SocketError
eduardoj marked this conversation as resolved.
Show resolved Hide resolved
hostname = ''
end
Expand Down