Skip to content

Commit

Permalink
Show Update error type on logs if unknown
Browse files Browse the repository at this point in the history
Update is failing due to unknown update dbus error type
but the cause can not be determined as its value is not showing.

This change is to add the error cause to journal in addition to
CRITICAL internalError.

```
Aug 02 09:00:16 bmcweb[2476]: (2023-08-02 09:00:14) [ERROR
    "update_service.hpp":396] Unknown Software Image Error type = <XXX>
Aug 02 09:00:16 bmcweb[2476]: (2023-08-02 09:00:14) [CRITICAL
    "error_messages.cpp":284] Internal Error ....`
```

Not tested but successfully compiled.

Change-Id: I20833d24042bf8d2f7e2d8a8e4359e3d80af702a
Signed-off-by: Myung Bae <myungbae@us.ibm.com>
  • Loading branch information
baemyung committed Aug 3, 2023
1 parent d518a9b commit 1ccf70f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions redfish-core/lib/update_service.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,8 @@ static void monitorForSoftwareAvailable(
}
else
{
BMCWEB_LOG_ERROR("Unknown Software Image Error type={}",
*type);
redfish::messages::internalError(asyncResp->res);
}
}
Expand Down

0 comments on commit 1ccf70f

Please sign in to comment.