Contributing a Pull Request
Justin Miranda edited this page Jul 16, 2019
·
3 revisions
These articles were used to write these instructions. If we made any errors, email us at support@openboxes.com with any feedback/suggestions.
- https://guides.github.com/activities/forking/
- https://help.github.com/en/articles/syncing-a-fork
- https://gist.github.com/Chaser324/ce0505fbed06b947d962
- https://help.github.com/en/articles/creating-a-pull-request#changing-the-branch-range-and-destination-repository
- Create a fork of the openboxes/openboxes repository
- Clone fork to your local machine
git clone git@github.com:<username>/openboxes.git
- Add openboxes repo as upstream (one-time only)
git remote add upstream git://github.com/openboxes/openboxes.git
- Fetch changes from upstream
git fetch upstream
- Sync develop
git checkout develop git pull upstream develop
All bug fixes / improvements should be created as branches off the develop branch
- Checkout develop branch
git checkout -b feature/<ticket-number-and-description>
e.g. feature/1084-make-uploads-directory-configurable
- Do all development in branch
git add application.properties git commit -m "Made a change to source file"
- Push all changes to branch in your forked repository
git push
- Create a pull request
- Title of the pull request should be the same as commit message
- Check openboxes/openboxes to see if pull request shows up in list https://github.com/openboxes/openboxes/pulls