Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toml markup for Platform struct #1074

Closed
wants to merge 1 commit into from

Conversation

kiashok
Copy link

@kiashok kiashok commented Jun 6, 2023

Addresses issue #1073 to add toml markup for Platform struct

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@kiashok
Copy link
Author

kiashok commented Jun 12, 2023

ping on this PR

@tianon
Copy link
Member

tianon commented Jun 23, 2023

(soft) NACK; #1073 (comment) (see also pelletier/go-toml#880)

(Soft because I'm still willing to be convinced, but I think we need more spec maintainer opinions to be expressed for this to really move one way or the other)

@sudo-bmitch
Copy link
Contributor

This gets a decline from me as well unless there's a response to #1073 (comment) showing why it's needed.

@sudo-bmitch
Copy link
Contributor

This was brought up in today's meeting (cleaning up old PRs) and the decision was to defer to the TOML default parsing of the struct, or to have the containerd specific requirements happen outside of the OCI spec. Our use of JSON aligns with the rest of the spec that marshals the data into JSON for the descriptors and config blob content. So without a TOML use case here, it didn't make sense to add into OCI directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants