test: add retry for killing container with host pidns #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifubang
force-pushed
the
fix-test-kill-hostpidns
branch
2 times, most recently
from
ee034a4
to
c9fd3bd
Compare
Signed-off-by: lifubang <lifubang@acmcoder.com>
lifubang
force-pushed
the
fix-test-kill-hostpidns
branch
from
c9fd3bd
to
952cec9
Compare
kolyshkin
reviewed
Jan 8, 2024
| # Make sure all processes are gone. | ||
| pids=$(cat "$cgpath"/cgroup.procs) || true # OK if cgroup is gone | ||
| echo "pids: $pids" | ||
| if [ -n "$pids" ]; then |
There was a problem hiding this comment.
nit: no need for this condition
kolyshkin
reviewed
Jan 8, 2024
| while [ $retry -lt 10 ] && [ -n "$pids" ]; do | ||
| # Make sure all processes are gone. | ||
| pids=$(cat "$cgpath"/cgroup.procs) || true # OK if cgroup is gone | ||
| echo "pids: $pids" |
There was a problem hiding this comment.
I'd add retry counter here, e.g.
echo "try $retry; pids: $pids"
kolyshkin
reviewed
Jan 8, 2024
| pids=$(cat "$cgpath"/cgroup.procs) || true # OK if cgroup is gone | ||
| echo "pids: $pids" | ||
| retry=0 | ||
| while [ $retry -lt 10 ] && [ -n "$pids" ]; do |
There was a problem hiding this comment.
you can do
while [ $((retry++)) -lt 10 ] && [ -n "$pids" ]; do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing kill container with host pidns:
stopped, so no need to wait it becomesstoppedafter killing;runc kill cid KILL, there are still some process exists in the cgroup if we view it immediately, so add a retry to wait all processes gone.Fix: #4163