Support binary payloads and responses, and non-UTF8 string payloads for Python functions #217
Conversation
Signed-off-by: Johan Pauwels <johan.pauwels@gmail.com>
Signed-off-by: Johan Pauwels <johan.pauwels@gmail.com>
|
I think this looks good, @alexellis what do you think? |
|
I haven't had a chance to look at it yet. It may be better just to use the existing support for binary responses in the HTTP/flask templates that I added whilst building out the LF training course on serverless |
| if ret != None: | ||
| print(ret) | ||
|
|
||
| # encode response to JSON if necessary |
There was a problem hiding this comment.
This part seems fine in principle, but be aware that you also need to set the mime type in the function's deployment. It cannot be dynamic with the classic watchdog.
| st = get_stdin() | ||
| st = sys.stdin.buffer.read() | ||
| # decode text to string | ||
| content_type, type_options = parse_header(os.getenv('Http_Content_Type', '')) |
There was a problem hiding this comment.
You don't mention application/x-www-form-urlencoded in the PR description?
|
Quite a few changes and output from testing. It would be good to see a sample GitHub repo where you have deployed samples from each of the scenarios that are supported in the response writing code. |
|
@jpauwels we didn't hear back from you after providing feedback, so I'm going to assume you're no longer interested in seeing this through. For anyone else landing here, do check out the python3-flask/http templates in the store. These are in a separate repository in this organisation. |
|
/add label: abandoned |
closes #205 and replaces #207
Description
In addition to handling binary input as in #207, this PR also handles binary output, properly encodes returned Python dicts as compliant JSON (double quotes instead of single quotes) and can handle all text encodings. All this processing is controlled by the headers according to web standards.
Motivation and Context
Which issue(s) this PR fixes
Fixes #205
How Has This Been Tested?
Deployed on an internal project that takes audio files/JSON as payload and response, running on Ubuntu and macOS.
Types of changes
Impact to existing users
UTF8 text payloads (the only ones supported so far) are passed as before.
Checklist:
git commit -s