Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332105: Exploded JDK does not include CDS #19188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented May 11, 2024

An exploded JDK cannot be used with either -Xshare:on or -Xshare:auto. That causes tests like runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java to fail when running on an exploded JDK.

Since an exploded JDK cannot use CDS, we should - for tests - treat it as if CDS had not been included.

/label hotspot


Note that I was torn between two ways to fix this:

The latter is cleaner and clearer, conveying the message of exploded-ness without muddling it with the CDS aspect. But OTOH the complexity may not be required.

I can go either way, though I have a slight preference for this PR, which is why I posted it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332105: Exploded JDK does not include CDS (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19188/head:pull/19188
$ git checkout pull/19188

Update a local copy of the PR:
$ git checkout pull/19188
$ git pull https://git.openjdk.org/jdk.git pull/19188/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19188

View PR using the GUI difftool:
$ git pr show -t 19188

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19188.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2024

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8332105: Exploded JDK should count as if CDS had not been included in the build 8332105: Exploded JDK should count as if CDS had not been included in the build May 11, 2024
@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label May 11, 2024
@openjdk
Copy link

openjdk bot commented May 11, 2024

@tstuefe
The hotspot label was successfully added.

@tstuefe tstuefe changed the title 8332105: Exploded JDK should count as if CDS had not been included in the build 8332105: Exploded JDK does not include CDS May 11, 2024
@tstuefe tstuefe marked this pull request as ready for review May 11, 2024 09:59
@openjdk openjdk bot added the rfr Pull request is ready for review label May 11, 2024
@mlbridge
Copy link

mlbridge bot commented May 11, 2024

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented May 23, 2024

Any takers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review
1 participant