8332105: Exploded JDK does not include CDS #19188
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exploded JDK cannot be used with either -Xshare:on or -Xshare:auto. That causes tests like runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java to fail when running on an exploded JDK.
Since an exploded JDK cannot use CDS, we should - for tests - treat it as if CDS had not been included.
/label hotspot
Note that I was torn between two ways to fix this:
@requires
propertyWhiteBox
andVMProps
(jdk.exploded
). See this draft PR: 8332074: Create a "jdk.exploded" test property to check if the testee jdk is exploded #19178 .The latter is cleaner and clearer, conveying the message of exploded-ness without muddling it with the CDS aspect. But OTOH the complexity may not be required.
I can go either way, though I have a slight preference for this PR, which is why I posted it.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19188/head:pull/19188
$ git checkout pull/19188
Update a local copy of the PR:
$ git checkout pull/19188
$ git pull https://git.openjdk.org/jdk.git pull/19188/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19188
View PR using the GUI difftool:
$ git pr show -t 19188
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19188.diff
Webrev
Link to Webrev Comment