Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332099: Add @since to package-info in jdk.jsobject #19197

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nizarbenalla
Copy link
Contributor

@nizarbenalla nizarbenalla commented May 12, 2024

Simple code cleanup.
If you're reviewing this, thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332099: Add @<!---->since to package-info in jdk.jsobject (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19197/head:pull/19197
$ git checkout pull/19197

Update a local copy of the PR:
$ git checkout pull/19197
$ git pull https://git.openjdk.org/jdk.git pull/19197/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19197

View PR using the GUI difftool:
$ git pr show -t 19197

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19197.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2024

👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 12, 2024

@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@nizarbenalla nizarbenalla marked this pull request as ready for review May 12, 2024 18:53
@openjdk openjdk bot added the rfr Pull request is ready for review label May 12, 2024
@AlanBateman
Copy link
Contributor

/label add client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@AlanBateman
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
2 participants