Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332098: Add missing @ since tags to jdk.jdi #19200

Closed
wants to merge 2 commits into from

Conversation

nizarbenalla
Copy link
Contributor

@nizarbenalla nizarbenalla commented May 12, 2024

Please review this simple change where I add "@ since" tags to the package-info file of the following packages

com.sun.jdi
com.sun.jdi.connect
com.sun.jdi.connect.spi
com.sun.jdi.event
com.sun.jdi.request

I used the unix grep command to find the oldest "@ since" in each package and used that value, as it's hard to get the source code of JDK 1-5
TIA


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332098: Add missing @ since tags to jdk.jdi (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19200/head:pull/19200
$ git checkout pull/19200

Update a local copy of the PR:
$ git checkout pull/19200
$ git pull https://git.openjdk.org/jdk.git pull/19200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19200

View PR using the GUI difftool:
$ git pr show -t 19200

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19200.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2024

👋 Welcome back nizarbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 12, 2024

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332098: Add missing @ since tags to jdk.jdi

Reviewed-by: alanb, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @plummercj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented May 12, 2024

@nizarbenalla The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label May 12, 2024
@nizarbenalla nizarbenalla marked this pull request as ready for review May 12, 2024 19:23
@openjdk openjdk bot added the rfr Pull request is ready for review label May 12, 2024
@mlbridge
Copy link

mlbridge bot commented May 12, 2024

Webrevs

@AlanBateman
Copy link
Contributor

JPDA was added to the JDK in JDK 1.3. The support for pluggable connectors (added com.sun.jdi.connect.spi package) was JDK 5. So I think this looks okay.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 13, 2024
@nizarbenalla
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@nizarbenalla
Your change (at version 39b7ee7) is now ready to be sponsored by a Committer.

@plummercj
Copy link
Contributor

Can you fix the summary of the CR to not have backwards quotes. This seems to cause git some grief, as can be seen where the CR is mentioned in the Issue section of the PR description.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label May 13, 2024
@nizarbenalla
Copy link
Contributor Author

Done, I tend to use them for formatting.
And there are users with names such as "@ since" that would keep getting tagged.

@nizarbenalla
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@nizarbenalla
Your change (at version 2ec2b52) is now ready to be sponsored by a Committer.

@nizarbenalla nizarbenalla changed the title 8332098: Add missing @since tags to jdk.jdi 8332098: Add missing @since tags to jdk.jdi May 13, 2024
@nizarbenalla nizarbenalla changed the title 8332098: Add missing @since tags to jdk.jdi 8332098: Add missing @ since tags to jdk.jdi May 13, 2024
@jaikiran
Copy link
Member

No changes have been done to the PR since it was last approved by Chris few days back (that's a good thing). I'll go ahead and sponsor this now.

@jaikiran
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 16, 2024

Going to push as commit a33cb90.
Since your change was applied there have been 50 commits pushed to the master branch:

  • 910d77b: 8331953: ubsan: metaspaceShared.cpp:1305:57: runtime error: applying non-zero offset 12849152 to null pointer
  • f9f8d0b: 8332101: Add an @since to StandardOperation:REMOVE in jdk.dynalink
  • f398cd2: 8331575: C2: crash when ConvL2I is split thru phi at LongCountedLoop
  • 96c5c3f: 8329998: Remove double initialization for parts of small TypeArrays in ZObjArrayAllocator
  • ee4a9d3: 8321622: ClassFile.verify(byte[] bytes) throws unexpected ConstantPoolException, IAE
  • ab8d7b0: 8324517: C2: crash in compiled code because of dependency on removed range check CastIIs
  • fe8a2af: 8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory
  • 95f79c6: 8332253: Linux arm32 build fails after 8292591
  • b687aa5: 8332176: Refactor ClassListParser::parse()
  • 4083255: 8316138: Add GlobalSign 2 TLS root certificates
  • ... and 40 more: https://git.openjdk.org/jdk/compare/32c7681cf310c87669c502c4a8b62a7fecc93360...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2024
@openjdk openjdk bot closed this May 16, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 16, 2024
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

@jaikiran @nizarbenalla Pushed as commit a33cb90.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
4 participants