Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331723: Serial: Remove the unused parameter of the method SerialHeap::gc_prologue #19207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaotaonan
Copy link

@xiaotaonan xiaotaonan commented May 12, 2024

Serial: Remove the unused parameter of the method SerialHeap::gc_prologue


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331723: Serial: Remove the unused parameter of the method SerialHeap::gc_prologue (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19207/head:pull/19207
$ git checkout pull/19207

Update a local copy of the PR:
$ git checkout pull/19207
$ git pull https://git.openjdk.org/jdk.git pull/19207/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19207

View PR using the GUI difftool:
$ git pr show -t 19207

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19207.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2024

👋 Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 12, 2024

@xiaotaonan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331723: Serial: Remove the unused parameter of the method SerialHeap::gc_prologue

Reviewed-by: gli, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • a33cb90: 8332098: Add missing @ since tags to jdk.jdi
  • 910d77b: 8331953: ubsan: metaspaceShared.cpp:1305:57: runtime error: applying non-zero offset 12849152 to null pointer
  • f9f8d0b: 8332101: Add an @since to StandardOperation:REMOVE in jdk.dynalink
  • f398cd2: 8331575: C2: crash when ConvL2I is split thru phi at LongCountedLoop
  • 96c5c3f: 8329998: Remove double initialization for parts of small TypeArrays in ZObjArrayAllocator
  • ee4a9d3: 8321622: ClassFile.verify(byte[] bytes) throws unexpected ConstantPoolException, IAE
  • ab8d7b0: 8324517: C2: crash in compiled code because of dependency on removed range check CastIIs
  • fe8a2af: 8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory
  • 95f79c6: 8332253: Linux arm32 build fails after 8292591
  • b687aa5: 8332176: Refactor ClassListParser::parse()
  • ... and 40 more: https://git.openjdk.org/jdk/compare/5053b70a7fc67ce9b73dbeecbdd88fbc34d45e04...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lgxbslgx, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 12, 2024
@openjdk
Copy link

openjdk bot commented May 12, 2024

@xiaotaonan The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label May 12, 2024
@mlbridge
Copy link

mlbridge bot commented May 12, 2024

Webrevs

@xiaotaonan
Copy link
Author

@lgxbslgx

@xiaotaonan
Copy link
Author

/signed

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

You are already a known contributor!

Copy link
Member

@lgxbslgx lgxbslgx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

virtual void gc_prologue(bool full);
virtual void gc_prologue();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gc_prologue and gc_epilogue don't need to be marked as virtual. This can be done at another ticket.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 13, 2024
@albertnetymk
Copy link
Member

I believe this PR should go in after #19056, as "is blocked by" indicates.

@albertnetymk
Copy link
Member

@xiaotaonan There's some merge conflicts to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
4 participants