-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NAPTR record support #17
base: master
Are you sure you want to change the base?
Conversation
20dff56
to
5dcc817
Compare
@sergey-lukin Thanks for the patch. But will you also add some docs and tests for this new feature? Many thanks! |
@@ -209,6 +211,16 @@ local function _encode_name(s) | |||
return char(#s) .. s | |||
end | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style: we need 2 blank lines to separate function definitions.
@sergey-lukin Please rebase to the latest master branch which includes a fix for Travis CI. Also, it would be perfect if you can also add some test cases for this new feature to the existing test suite. Many thanks! |
Thank you for practical advises. I have fixed everything you asked except adding tests. I can do it later when I'll have some time for it. I would be grateful if you give me some help or hint about adding tests. |
@sergey-lukin I think you can just check out existing test cases in the https://openresty.gitbooks.io/programming-openresty/content/testing/ Thank you for your contributions! |
No description provided.