feat: sbomgen refactor #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the skeleton of a mockable runner package. The package has a generator object that executes all the SBOM generation logic. It relies on two underlying objects: the implementation and the document format handler. - The implementation handles all the generator main functions. - All the format-specific code lies in the format handler which can be swapped out for each format supported by the generator. This is a skeleton only, the logic needs to be implemented still. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Signed-off-by: Rahul Tiwari <jprrahultiwari@gmail.com>
Signed-off-by: Rahul Tiwari <jprrahultiwari@gmail.com>
Signed-off-by: Rahul Tiwari <jprrahultiwari@gmail.com>
Signed-off-by: Rahul Tiwari <jprrahultiwari@gmail.com>
- use error wrapping to bubble up errors - cleanup sorting of modules since the packages are later sorted according to the package identifier - some comments Signed-off-by: Rahul Tiwari <jprrahultiwari@gmail.com>
Signed-off-by: Rahul Tiwari <jprrahultiwari@gmail.com>
Signed-off-by: Rahul Tiwari <jprrahultiwari@gmail.com>
Signed-off-by: Rahul Tiwari <jprrahultiwari@gmail.com>
nishakm
reviewed
Aug 9, 2023
|
@puerco this PR looks good to me. Can you review? |
ba11b0y
commented
Aug 10, 2023
puerco
approved these changes
Aug 11, 2023
This was referenced Aug 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spdx-sbom-generatorv2.2andv2.3