Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to kube 1.12.5 #186

Merged
merged 4 commits into from Jan 28, 2019
Merged

bump to kube 1.12.5 #186

merged 4 commits into from Jan 28, 2019

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 28, 2019

Had to move and fix a test. Gengo is still out of date, we'll need to decide what do about that.

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 28, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Jan 28, 2019

/retest

soltysh
soltysh approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 130a85a into openshift:master Jan 28, 2019
@machine424 machine424 mentioned this pull request Apr 24, 2024
Open
2 tasks
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7f664b50-0259-11ef-9185-24d6ca106a44-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ba9a7f80-0302-11ef-8a85-ad9333c8812f-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deads2k @openshift-ci-robot @soltysh @openshift-merge-robot