Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2517: openshift: promote core CAPI IPAM CRDs to GA #197

Conversation

damdo
Copy link
Member

@damdo damdo commented Feb 15, 2024

Update the manifest by removing the:
release.openshift.io/feature-set: CustomNoUpgrade,TechPreviewNoUpgrade annotation to
Core CAPI IPAM CRDs as we want to promote it to GA.

TODO:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 15, 2024

@damdo: This pull request references OCPCLOUD-2517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Update the manifest by removing the:
release.openshift.io/feature-set: CustomNoUpgrade,TechPreviewNoUpgrade annotation to
Core CAPI IPAM CRDs as we want to promote it to GA.

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2024
Copy link

openshift-ci bot commented Feb 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@damdo damdo force-pushed the openshift-promote-core-capi-ipam-crds-to-ga branch from 8add538 to 77bacd8 Compare February 16, 2024 09:28
@damdo damdo marked this pull request as ready for review February 16, 2024 09:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2024

@damdo: This pull request references OCPCLOUD-2517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Update the manifest by removing the:
release.openshift.io/feature-set: CustomNoUpgrade,TechPreviewNoUpgrade annotation to
Core CAPI IPAM CRDs as we want to promote it to GA.

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo
Copy link
Member Author

damdo commented Feb 16, 2024

/hold
until SPLAT (@vr4manta) is happy with it to merge.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2024
@JoelSpeed
Copy link

/approve

Neil to add LGTM when happy

Copy link

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member Author

damdo commented Feb 16, 2024

/test ci/prow/e2e-hypershift

Copy link

openshift-ci bot commented Feb 16, 2024

@damdo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-capi-techpreview
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-techpreview
  • /test e2e-aws-serial
  • /test e2e-gcp-capi-techpreview
  • /test e2e-hypershift
  • /test e2e-openstack-capi-techpreview
  • /test images
  • /test unit

The following commands are available to trigger optional jobs:

  • /test verify-commits

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member Author

damdo commented Feb 16, 2024

/test e2e-hypershift

Copy link

openshift-ci bot commented Feb 16, 2024

@vr4manta: This PR was included in a payload test run from openshift/installer#7943
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-static-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8b4cf8e0-ccd2-11ee-9ec5-3e170f3c0868-0

@damdo
Copy link
Member Author

damdo commented Feb 19, 2024

/test e2e-hypershift

Copy link

openshift-ci bot commented Feb 19, 2024

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vr4manta
Copy link

/lgtm
Changes look great. Tested w/ my PR.

@vr4manta
Copy link

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@vr4manta
Copy link

/lgtm

@openshift-merge-bot openshift-merge-bot bot merged commit a009f85 into openshift:master Feb 21, 2024
11 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-api-container-v4.16.0-202402211939.p0.ga009f85.assembly.stream.el9 for distgit ose-cluster-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants