Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METAL-745: Make CBO aware of HostFirmwareComponents #414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iurygregory
Copy link
Contributor

@iurygregory iurygregory commented Apr 19, 2024

This PR updates BMO to point to the latest version we have downstream,
the version includes changes that are necessary for
HostFirmwareComponents.

⚠️ NOTE: with controller-runtime 0.16.3 a lot of things changed on how
we can specify NewCache, I'm attempting to simplify things by using
Cache instead of NewCache.
I was necessary to update the FakeClient used in our testing
⚠️

Also includes hostfirmwarecomponents in relatedObjects for the
clusteroperator controller.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 19, 2024

@iurygregory: This pull request references METAL-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR updates BMO to point to the latest version we have downstream, the version includes changes that are necessary for HostFirmwareComponents.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 19, 2024
@openshift-ci openshift-ci bot requested review from andfasano and zaneb April 19, 2024 13:43
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iurygregory
Once this PR has been reviewed and has the lgtm label, please assign andfasano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

go.mod Outdated Show resolved Hide resolved
@iurygregory iurygregory force-pushed the sync-with-bmo branch 3 times, most recently from 82bf279 to a0564e2 Compare April 19, 2024 17:14
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 19, 2024

@iurygregory: This pull request references METAL-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR updates BMO to point to the latest version we have downstream,
the version includes changes that are necessary for
HostFirmwareComponents.

⚠️ NOTE: with controller-runtime 0.16.3 a lot of things changed on how
we can specify NewCache, I'm attempting to simplify things by using
Cache instead of NewCache.
⚠️

Also includes hostfirmwarecomponents in relatedObjects for the
clusteroperator controller.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This PR updates BMO to point to the latest version we have downstream,
the version includes changes that are necessary for
HostFirmwareComponents.

NOTE: with controller-runtime 0.16.3  a lot of things changed on how
we can specify NewCache, I'm attempting to simplify things by using
`Cache` instead of `NewCache`.

Also includes hostfirmwarecomponents in relatedObjects for the
clusteroperator controller.

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 19, 2024

@iurygregory: This pull request references METAL-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR updates BMO to point to the latest version we have downstream,
the version includes changes that are necessary for
HostFirmwareComponents.

⚠️ NOTE: with controller-runtime 0.16.3 a lot of things changed on how
we can specify NewCache, I'm attempting to simplify things by using
Cache instead of NewCache.
I was necessary to also update the FakeClient used in our testing
⚠️

Also includes hostfirmwarecomponents in relatedObjects for the
clusteroperator controller.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 19, 2024

@iurygregory: This pull request references METAL-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR updates BMO to point to the latest version we have downstream,
the version includes changes that are necessary for
HostFirmwareComponents.

⚠️ NOTE: with controller-runtime 0.16.3 a lot of things changed on how
we can specify NewCache, I'm attempting to simplify things by using
Cache instead of NewCache.
I was necessary to update the FakeClient used in our testing
⚠️

Also includes hostfirmwarecomponents in relatedObjects for the
clusteroperator controller.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@iurygregory
Copy link
Contributor Author

/retest

@iurygregory
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-serial-virtualmedia
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-single-node-live-iso
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm

Copy link
Contributor

openshift-ci bot commented Apr 20, 2024

@iurygregory: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-serial-virtualmedia
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-single-node-live-iso
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/80e01420-ff66-11ee-9f42-befe5dd7d559-0

@iurygregory
Copy link
Contributor Author

/test e2e-metal-ipi-serial-ipv4

@iurygregory
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-serial-virtualmedia

A lot of connection timeout in logs

Copy link
Contributor

openshift-ci bot commented Apr 21, 2024

@iurygregory: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-serial-virtualmedia

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a1b500a0-0012-11ef-9910-fa6accfaa7c0-0

@iurygregory
Copy link
Contributor Author

/test e2e-metal-ipi-upgrade

@iurygregory
Copy link
Contributor Author

/test e2e-metal-ipi-upgrade-ovn-ipv6

@iurygregory
Copy link
Contributor Author

proxyconnect tcp: dial tcp : i/o timeout
/test e2e-metal-ipi-serial-ipv4

@iurygregory
Copy link
Contributor Author

@iurygregory
Copy link
Contributor Author

APIServerDeploymentDegraded: 1 of 3 requested instances are unavailable for apiserver.openshift-oauth-apiserver

/test e2e-metal-ipi-upgrade

@iurygregory
Copy link
Contributor Author

Couldn't really figure out the problem in the upgrade ipv6
retesting
/test e2e-metal-ipi-upgrade-ovn-ipv6

Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@iurygregory: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-upgrade df6be4e link false /test e2e-metal-ipi-upgrade
ci/prow/e2e-metal-ipi-upgrade-ovn-ipv6 df6be4e link false /test e2e-metal-ipi-upgrade-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants