New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
METAL-745: Make CBO aware of HostFirmwareComponents #414
base: master
Are you sure you want to change the base?
Conversation
@iurygregory: This pull request references METAL-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iurygregory The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
82bf279
to
a0564e2
Compare
@iurygregory: This pull request references METAL-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This PR updates BMO to point to the latest version we have downstream, the version includes changes that are necessary for HostFirmwareComponents. NOTE: with controller-runtime 0.16.3 a lot of things changed on how we can specify NewCache, I'm attempting to simplify things by using `Cache` instead of `NewCache`. Also includes hostfirmwarecomponents in relatedObjects for the clusteroperator controller. Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
a0564e2
to
df6be4e
Compare
@iurygregory: This pull request references METAL-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@iurygregory: This pull request references METAL-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-serial-virtualmedia |
@iurygregory: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/80e01420-ff66-11ee-9f42-befe5dd7d559-0 |
/test e2e-metal-ipi-serial-ipv4 |
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-serial-virtualmedia A lot of connection timeout in logs |
@iurygregory: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a1b500a0-0012-11ef-9910-fa6accfaa7c0-0 |
/test e2e-metal-ipi-upgrade |
/test e2e-metal-ipi-upgrade-ovn-ipv6 |
proxyconnect tcp: dial tcp : i/o timeout |
|
APIServerDeploymentDegraded: 1 of 3 requested instances are unavailable for apiserver.openshift-oauth-apiserver /test e2e-metal-ipi-upgrade |
Couldn't really figure out the problem in the upgrade ipv6 |
@iurygregory: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR updates BMO to point to the latest version we have downstream,
the version includes changes that are necessary for
HostFirmwareComponents.
we can specify NewCache, I'm attempting to simplify things by using
Cache
instead ofNewCache
.I was necessary to update the FakeClient used in our testing
Also includes hostfirmwarecomponents in relatedObjects for the
clusteroperator controller.