SPLAT-1440: prevent rollout due to irrelevant path artifacts #275
Conversation
|
@rvanderp3: This pull request references SPLAT-1440 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test unit |
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
size/L
rvanderp3
changed the title
|
@rvanderp3: This PR was included in a payload test run from openshift/api#1759
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7ef73120-c695-11ee-97df-fe0ba4c7dde6-0 |
|
@rvanderp3: This PR was included in a payload test run from openshift/api#1759
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/163edea0-c6c5-11ee-9a19-8791530867b9-0 |
rvanderp3
changed the title
|
@rvanderp3: This pull request references SPLAT-1440 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
rvanderp3
force-pushed
the
SPLAT-1440
branch
from
2746ad6
to
78cde55
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@rvanderp3: This pull request references SPLAT-1440 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
size/XXL
|
/retest-required |
1 similar comment
|
/retest-required |
rvanderp3
force-pushed
the
SPLAT-1440
branch
from
e480918
to
6fa378d
Compare
|
/test unit |
1 similar comment
|
/test unit |
|
/test e2e-vsphere-operator |
rvanderp3
force-pushed
the
SPLAT-1440
branch
2 times, most recently
from
e4df248
to
653e795
Compare
| func setInfrastructure(infra configv1.Infrastructure) error { | ||
|
|
||
| return nil |
There was a problem hiding this comment.
we can drop this as well
|
/test unit |
|
/assign @jcpowermac |
|
/lgtm |
|
/assign @JoelSpeed |
|
/assign @damdo |
| ))) | ||
| }) | ||
|
|
||
| It("when providing failure domains in vSphere configuration", func() { |
There was a problem hiding this comment.
Gotcha, maybe we could add this description you provided as a comment on top of the It 👍
|
|
||
| for i := 0; i < 3; i++ { | ||
| controlPlaneMachine := controlPlaneMachineBuilder.Build() | ||
| Expect(k8sClient.Create(ctx, controlPlaneMachine)).To(Succeed(), "expected to be able to create the control plane machinset") |
There was a problem hiding this comment.
It looks like we have a typo machinset here and in other 12 occurrences
There was a problem hiding this comment.
The preferred spelling is control plane machine set, as per docs guidelines
|
@JoelSpeed said he's happy with this. CI failures:
Plus all these are optional ☝️ Based on this |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@rvanderp3: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit baeb063
into
openshift:main
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-control-plane-machine-set-operator-container-v4.16.0-202403111814.p0.gbaeb063.assembly.stream.el9 for distgit ose-cluster-control-plane-machine-set-operator. |
|
Will it back port to 4.15? IIRC https://issues.redhat.com/browse/OCPBUGS-29236 need to get verified after it back port to 4.15. |
changes: