Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METAL-871: baremetal: bootstrap: rename master label #8107

Merged
merged 1 commit into from Mar 8, 2024

Conversation

honza
Copy link
Member

@honza honza commented Mar 6, 2024

Let's use the new k8s upstream name.

This is a follow-up to #7649

Let's use the new k8s upstream name.
@dtantsur
Copy link
Member

dtantsur commented Mar 6, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@zaneb
Copy link
Member

zaneb commented Mar 7, 2024

Unit test failure is a flake.
/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
@honza honza changed the title baremetal: bootstrap: rename master label METAL-871: baremetal: bootstrap: rename master label Mar 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 7, 2024

@honza: This pull request references METAL-871 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Let's use the new k8s upstream name.

This is a follow-up to #7649

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 7, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1b99648 and 2 for PR HEAD deb484f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e245acb and 1 for PR HEAD deb484f in total

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@honza: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn-swapped-hosts deb484f link false /test e2e-metal-ipi-sdn-swapped-hosts

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0e2c277 and 0 for PR HEAD deb484f in total

@openshift-merge-bot openshift-merge-bot bot merged commit fc57118 into openshift:master Mar 8, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants