Skip to content

WIP: test(e2e/vsphere/machines.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: test(e2e/vsphere/machines.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers #1409

wants to merge 1 commit into from

Conversation

machine424
Copy link

No description provided.

machine424
machine424 commented Sep 4, 2025
View reviewed changes
test/e2e/vsphere/machines.go
// Remove machine
By("delete the machine")
err = mc.Machines(util.MachineAPINamespace).Delete(ctx, machine.Name, metav1.DeleteOptions{})
policy := metav1.DeletePropagationForeground
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this is implemented by the controller, let's see

machine424
machine424 commented Sep 4, 2025
View reviewed changes
test/e2e/vsphere/machines.go
err = mc.MachineSets(util.MachineAPINamespace).Delete(ctx, ddMachineSet.Name, metav1.DeleteOptions{PropagationPolicy: &policy})
Expect(err).NotTo(HaveOccurred())

// Verify / wait for machineset is removed
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming the policy is propagated to machines and is implemented, let's see

@openshift-ci openshift-ci bot requested review from damdo and racheljpg September 4, 2025 13:08
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@machine424
Copy link
Author

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial 10

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6a5b45d0-899e-11f0-876f-3fa2e09ebf24-0

@damdo
Copy link
Member

damdo commented Sep 5, 2025

Hey @machine424 can you explain a little why this change is required and how that fixes your issue, thanks!

@machine424 machine424 changed the title test(e2e/vsphere/machines.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers WIP: test(e2e/vsphere/machines.go): use DeletePropagationForeground policy while deleting CRs to avoid leftovers Sep 5, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@machine424
Copy link
Author

Hello @damdo
This is just an experiment, I was planning to reach out to you about it once I know more.
We’ve noticed that this test seems to leave some nodes behind, and a few subsequent tests don’t handle that well. I was trying out foreground deletion, if it’s implemented, it should help the test clean up the underlying resources after itself.

See https://issues.redhat.com/browse/OCPBUGS-61193?focusedId=27993433&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-27993433
let's continue the discussion there if you want.

@damdo
Copy link
Member

damdo commented Sep 10, 2025

Ok thanks do keep me posted on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo Awaiting requested review from damdo

@racheljpg racheljpg Awaiting requested review from racheljpg

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machine424 @damdo