OCPBUGS-22324: Revert "Revert "Merge pull request #4028 from cybertron/wait-for-br-ex"" #4079
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
cybertron
changed the title
openshift-ci-robot
added
jira/severity-important
|
@cybertron: This pull request references Jira Issue OCPBUGS-22324, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@cybertron: This pull request references Jira Issue OCPBUGS-22324, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (yprokule@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-metal-ipi Leaving as draft until I confirm that we've run the necessary payload jobs to verify the fix. |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-sdn-bm Looks like the metal-ipi jobs failed to acquire a test env. Unrelated to this change. |
|
@cybertron: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2ec02870-9ad9-11ee-83b0-f56a0071c00a-0 |
|
@cybertron - I missed this in my slack comment but your probably need to run the 4.16 job now sorry about that.
|
|
Ah, yeah that makes sense. /payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm |
|
@cybertron: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/34f58760-9b71-11ee-910c-9784f1475145-0 |
|
/test e2e-metal-ipi-ovn-dualstack Looks like there were metal infra issues around the time these jobs were last run. Let's see if they pass now. |
|
@cybertron: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bdc4b320-a9ba-11ee-960e-5f3a9df97ee3-0 |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm |
|
@cybertron: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/542f5d60-b3ca-11ee-9e77-3535e5226427-0 |
|
/test e2e-metal-ipi |
|
Looks like the e2e jobs are passing now. The payload job failed on a name mismatch which has nothing to do with this. I'll have to see what's going on there. |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm |
|
@cybertron: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2863d650-b629-11ee-8c26-402fb7586591-0 |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm Looks like node provisioning failed this time, so we never got to the point where this would run. |
|
@cybertron: trigger 1 job(s) for the /payload-(job|aggregate|job-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5d6b11f0-b6e8-11ee-8ec2-3377fa9cb686-0 |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm Failed later in the process, but seems to have gotten past where this change would be relevant. No logs captured that I can find so hard to say more than that. |
|
@cybertron: trigger 1 job(s) for the /payload-(job|aggregate|job-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5522e0b0-b952-11ee-9e3b-4c3bbb7c1bea-0 |
|
Payload job finally passed: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-machine-config-operator-4079-nightly-4.16-e2e-metal-ipi-sdn-bm/1749496228007120896 Looks like we should be good to go, pending the other jobs passing. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/assign @sinnykumari |
…-for-br-ex"" This reverts commit c558cc6.
The original version of this patch caused OpenShiftSDN to fail because it doesn't create br-ex so the interface never comes up. This commit fixes that by disabling the wait service when any CNI plugin other than OVNKubernetes is used.
cybertron
force-pushed
the
wait-for-br-ex-unrevert
branch
from
3d1947e
to
7e2e27a
Compare
|
/lgtm |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm Just a rebase, but let's make sure it still passes everything. |
|
@cybertron: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4518edf0-c1e4-11ee-8eb2-048dc045ec55-0 |
|
@cybertron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Required payload job |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, mkowalski, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-gcp-op-single-node |
openshift-merge-bot
bot
merged commit 4e12d91
into
openshift:master
|
@cybertron: Jira Issue OCPBUGS-22324: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-22324 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806 |
|
/cherry-pick release-4.15 |
|
@cybertron: new pull request created: #4232 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit c558cc6 and adds a commit to fix the problem that prompted the revert in the first place. Now the service will be disabled for all CNI plugins except OVNKubernetes.