Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1641 "WRKLDS-1012: oc adm must-gather: pull gather container logs" #1657

Closed
wants to merge 1 commit into from

Conversation

neisw
Copy link

@neisw neisw commented Jan 20, 2024

Reverts #1641 ; tracked by https://issues.redhat.com/browse/OCPBUGS-27442

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

core files found failures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

CC: @ingvagabund

PR created by Revertomatic™️

…r-pull-gather-container-logs"

This reverts commit 2062f14, reversing
changes made to dbcdd47.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2024

@neisw: This pull request references WRKLDS-1012 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #1641 ; tracked by https://issues.redhat.com/browse/OCPBUGS-27442

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

core files found failures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

CC: @ingvagabund

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neisw
Once this PR has been reviewed and has the lgtm label, please assign mfojtik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neisw
Copy link
Author

neisw commented Jan 20, 2024

/hold

Want to run payload testing to see what it shows

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2024
@neisw
Copy link
Author

neisw commented Jan 20, 2024

/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

Copy link
Contributor

openshift-ci bot commented Jan 20, 2024

@neisw: trigger 1 job(s) for the /payload-(job|aggregate|job-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c0c92a80-b7a5-11ee-87f3-9fb003556737-0

@ingvagabund
Copy link
Member

openshift/release#47889 for the fix

@neisw
Copy link
Author

neisw commented Jan 20, 2024

Running pj-rehearse periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade on openshift/release#47889 for validation

@neisw
Copy link
Author

neisw commented Jan 20, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Jan 20, 2024

@neisw: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@neisw
Copy link
Author

neisw commented Jan 21, 2024

/close

In favor of openshift/release#47889

@openshift-ci openshift-ci bot closed this Jan 21, 2024
Copy link
Contributor

openshift-ci bot commented Jan 21, 2024

@neisw: Closed this PR.

In response to this:

/close

In favor of openshift/release#47889

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants