Skip to content

OPRUN-3605: Update nodeSelector and tolerations on operator-controller deployment via kustomize patch #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

everettraven
Copy link
Contributor

Updates the nodeSelector and toleration on the operator-controller deployment via a kustomize patch to allow it to be scheduled on the master node.

…oller deployment via kustomize patch

Signed-off-by: everettraven <everettraven@gmail.com>
Signed-off-by: everettraven <everettraven@gmail.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 19, 2024
@openshift-ci-robot
Copy link

@everettraven: This pull request explicitly references no jira issue.

In response to this:

Updates the nodeSelector and toleration on the operator-controller deployment via a kustomize patch to allow it to be scheduled on the master node.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dtfranz and tmshort November 19, 2024 18:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
@grokspawn
Copy link
Contributor

grokspawn commented Nov 19, 2024

/retitle OPRUN-3605: Update nodeSelector and tolerations on operator-controller deployment via kustomize patch

@openshift-ci openshift-ci bot changed the title NO-ISSUE: Update nodeSelector and tolerations on operator-controller deployment via kustomize patch OPRUN-3605: Update nodeSelector and tolerations on operator-controller deployment via kustomize patch Nov 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024

@everettraven: This pull request references OPRUN-3605 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Updates the nodeSelector and toleration on the operator-controller deployment via a kustomize patch to allow it to be scheduled on the master node.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xueqzhan
Copy link

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-techpreview-serial openshift/operator-framework-catalogd#89 #194

Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b26ef170-a6a3-11ef-95b7-01008941c756-0

Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

@xueqzhan: This PR was included in a payload test run from #194
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b26ef170-a6a3-11ef-95b7-01008941c756-0

@tmshort
Copy link
Contributor

tmshort commented Nov 19, 2024

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 19, 2024
@joelanford
Copy link
Member

/hold
waiting for manual payload job to complete successfully

/override ci/prow/openshift-e2e-aws-techpreview

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

@joelanford: Overrode contexts on behalf of joelanford: ci/prow/openshift-e2e-aws-techpreview

In response to this:

/hold
waiting for manual payload job to complete successfully

/override ci/prow/openshift-e2e-aws-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

@everettraven: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@joelanford
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 950d164 into openshift:main Nov 19, 2024
8 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-operator-controller
This PR has been included in build ose-olm-operator-controller-container-v4.19.0-202411200236.p0.g950d164.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants