OCPBUGS-49683: cache bug fixes (round 2) #259
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@joelanford: This pull request references Jira Issue OCPBUGS-49683, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
joelanford
changed the title
|
@joelanford: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
…#1669) Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
…#1677) * Rename util package name and file Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> * Refactor and add missing unit tests Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> --------- Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
…e perms prior to delete (#1691) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
fix-cache-delete
branch
from
bbb79e1 to
eb54466
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node 10 |
|
@joelanford: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/62f2dad0-e262-11ef-981b-802b61a5ede3-0 |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Looks like we still have catalogd failures in sno |
|
I looked at the first failure's must-gather. Looking at the openshift-catalogd replicasets, I think I see that the older of the replicasets was running with the commit that we reverted. The newer replicaset shows the expected pod spec from main, and I see that the pod in the must gather has no previous logs. However I do see one restart of the new pod. Without the previous pod log, it's hard to tell why. Does "[sig-architecture] platform pods in ns/openshift-catalogd should not exit an excessive amount of times" capture restarts before and after the upgrade, or just after? I suspect it's counting failures from the known bad commit that was on |
|
Doh! It's right there! The log output of "[sig-architecture] platform pods in ns/openshift-catalogd should not exit an excessive amount of times" shows the failures due to the old replica set's pod, which is what we reverted. That test must have picked up a "from payload" version that had our bugged code. Cluster version history shows the "from" version was Once there's a new accepted CI payload with our revert, we should kickoff the payload jobs again. |
|
I'm seeing the excessive restarts in #260 as well, I might need to wait until this merges. |
|
@joelanford this can probably be closed as #266 finally merged from upstream? |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joelanford: This pull request references Jira Issue OCPBUGS-49683. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
No description provided.