Skip to content

OPRUN-4070: Revert "UPSTREAM: <carry>: [OTE] add webhook tests" #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sosiouxme
Copy link
Member

@sosiouxme sosiouxme commented Aug 14, 2025

This reverts commit 9963614.

Tests have a pass rate of only 85%; reference slack thread - this is causing problems for presubmits and will show up in payloads shortly. Per TRT policy we are reverting.

To reinstate, create a re-revert PR with fixes layered on top, and use it to run a payload job with /payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 10 - check all the jobs this runs, it should include the test and not fail more than 5% of the time (might want to run two sets).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2025

@sosiouxme: This pull request references OPRUN-4070 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This reverts commit 9963614.

Tests have a pass rate of only 85%; reference slack thread - this is causing problems for presubmits and will show up in payloads shortly. Per TRT policy we are reverting.

To reinstate, create a re-revert PR with fixes layered on top, and use it to run a payload job with /payload-aggregate pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial-2of2 10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from oceanc80 and tmshort August 14, 2025 19:39
Revert "UPSTREAM: <carry>: [OTE] add webhook tests"

This reverts commit 9963614.
@sosiouxme sosiouxme force-pushed the revert-424-1755199531045 branch from c452241 to e83aa20 Compare August 14, 2025 19:40
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2025

@sosiouxme: This pull request references OPRUN-4070 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This reverts commit 9963614.

Tests have a pass rate of only 85%; reference slack thread - this is causing problems for presubmits and will show up in payloads shortly. Per TRT policy we are reverting.

To reinstate, create a re-revert PR with fixes layered on top, and use it to run a payload job with /payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2025

@sosiouxme: This pull request references OPRUN-4070 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This reverts commit 9963614.

Tests have a pass rate of only 85%; reference slack thread - this is causing problems for presubmits and will show up in payloads shortly. Per TRT policy we are reverting.

To reinstate, create a re-revert PR with fixes layered on top, and use it to run a payload job with /payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 10 - check all the jobs this runs, it should include the test and not fail more than 5% of the time (might want to run two sets).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@neisw
Copy link
Contributor

neisw commented Aug 14, 2025

/retest-required

@neisw
Copy link
Contributor

neisw commented Aug 15, 2025

/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 10

Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fd1c4cf0-796a-11f0-8d45-7bf5d49d2c62-0

@camilamacedo86
Copy link
Contributor

/approved
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2025
@oceanc80
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oceanc80, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2025
@camilamacedo86
Copy link
Contributor

/test openshift-e2e-aws

@neisw
Copy link
Contributor

neisw commented Aug 15, 2025

/override ci/prow/openshift-e2e-aws
/skip

[sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s] is a known flake outside this pr

Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

@neisw: Overrode contexts on behalf of neisw: ci/prow/openshift-e2e-aws

In response to this:

/override ci/prow/openshift-e2e-aws
/skip

[sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s] is a known flake outside this pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d9f86c1 into openshift:main Aug 15, 2025
13 checks passed
Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

@sosiouxme: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn e83aa20 link false /test okd-scos-e2e-aws-ovn
ci/prow/openshift-e2e-aws-techpreview e83aa20 link false /test openshift-e2e-aws-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sosiouxme sosiouxme deleted the revert-424-1755199531045 branch August 15, 2025 13:41
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-catalogd
This PR has been included in build ose-olm-catalogd-container-v4.20.0-202508151344.p0.gd9f86c1.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants