Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29614: update control plane machine set test #28602

Merged
merged 1 commit into from Feb 23, 2024

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Feb 19, 2024

This change updates the test to skip when the Cluster object is not found. Usually this object is not found on clusters that have been deployed using the UPI methodology, as such there is no CPMSO in the cluster.

This change updates the test to skip when the Cluster object is not
found. Usually this object is not found on clusters that have been
deployed using the UPI methodology, as such there is no CPMSO in the
cluster.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2024
@openshift-ci-robot
Copy link

@elmiko: This pull request references Jira Issue OCPBUGS-29614, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change updates the test to skip when the Cluster object is not found. Usually this object is not found on clusters that have been deployed using the UPI methodology, as such there is no CPMSO in the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elmiko
Copy link
Contributor Author

elmiko commented Feb 19, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2024
@openshift-ci-robot
Copy link

@elmiko: This pull request references Jira Issue OCPBUGS-29614, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam
Copy link
Member

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-upi

Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-upi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/997557e0-cf58-11ee-80c5-4a3159689fd0-0

Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@elmiko: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 8caea4e link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-openstack-ovn 8caea4e link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial 8caea4e link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 8caea4e link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-upi

Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-upi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/87ef21e0-cf85-11ee-975c-5a04f7c26512-0

@elmiko
Copy link
Contributor Author

elmiko commented Feb 21, 2024

@stbenjam did that even make it to the test we wanted to see?

@stbenjam
Copy link
Member

Neither job passed, they may not work in /payload environment, will have to investigate. But skip condition looks fine to me

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024
Copy link
Contributor

openshift-ci bot commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9c9713e and 2 for PR HEAD 8caea4e in total

@openshift-merge-bot openshift-merge-bot bot merged commit 96d2578 into openshift:master Feb 23, 2024
18 of 22 checks passed
@openshift-ci-robot
Copy link

@elmiko: Jira Issue OCPBUGS-29614: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29614 has been moved to the MODIFIED state.

In response to this:

This change updates the test to skip when the Cluster object is not found. Usually this object is not found on clusters that have been deployed using the UPI methodology, as such there is no CPMSO in the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202402231109.p0.g96d2578.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-26-013420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants