New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-31074: fix: add check for static container #28662
OCPBUGS-31074: fix: add check for static container #28662
Conversation
@eggfoobar: This pull request references Jira Issue OCPBUGS-31074, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/hold Waiting for successful rt upgrade from clusterbot |
/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade |
@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7d1c4840-e6a2-11ee-9f6e-00f46f2b2bd0-0 |
added a check for static containers during the cpu affinity comparison between the host and expected value, this is done to account for the fact that static pods do not get altered by the workload webhook and on realtime deployments we have a bug where the CPU affinity changes for static pods that do not go through the workload partitioning feature This should be removed once the issue is fixed Signed-off-by: ehila <ehila@redhat.com>
00e0899
to
65aafff
Compare
/unhold The payload test passed, the static pod I updated the comment to reflect what's going on |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label acknowledge-critical-fixes-only |
Job Failure Risk Analysis for sha: 65aafff
|
/retest-required |
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
734b389
into
openshift:master
@eggfoobar: Jira Issue OCPBUGS-31074: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31074 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403210141.p0.g734b389.assembly.stream.el8 for distgit openshift-enterprise-tests. |
added a check for static containers during the cpu affinity comparison between the host and expected value, this is done to account for the fact that static pods do not get altered by the workload webhook and on realtime deployments we might get CPU affinity changes for static pods that do not go through the workload partitioning feature