Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31074: fix: add check for static container #28662

Merged

Conversation

eggfoobar
Copy link
Contributor

added a check for static containers during the cpu affinity comparison between the host and expected value, this is done to account for the fact that static pods do not get altered by the workload webhook and on realtime deployments we might get CPU affinity changes for static pods that do not go through the workload partitioning feature

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 20, 2024
@openshift-ci-robot
Copy link

@eggfoobar: This pull request references Jira Issue OCPBUGS-31074, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

added a check for static containers during the cpu affinity comparison between the host and expected value, this is done to account for the fact that static pods do not get altered by the workload webhook and on realtime deployments we might get CPU affinity changes for static pods that do not go through the workload partitioning feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ffromani and Tal-or March 20, 2024 00:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@xueqzhan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@eggfoobar
Copy link
Contributor Author

/hold

Waiting for successful rt upgrade from clusterbot

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@eggfoobar
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7d1c4840-e6a2-11ee-9f6e-00f46f2b2bd0-0

added a check for static containers during the cpu affinity comparison between the host and expected value,
this is done to account for the fact that static pods do not get altered by the workload webhook and on realtime deployments
we have a bug where the CPU affinity changes for static pods that do not go through the workload partitioning feature

This should be removed once the issue is fixed

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@eggfoobar
Copy link
Contributor Author

/unhold

The payload test passed, the static pod kube-rbac-proxy-crio was present with "target.workload.openshift.io/management": "{\"effect\": \"PreferredDuringScheduling\"}" being present as well. This fix should be good

I updated the comment to reflect what's going on

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@xueqzhan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eggfoobar
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 20, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2cecd5f and 2 for PR HEAD 65aafff in total

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 65aafff

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade High
[sig-apps] job-upgrade
This test has passed 100.00% of 24 runs on jobs ['periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn-upgrade'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (27) are below the historical average (371): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@eggfoobar
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade 65aafff link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-metal-ipi-sdn 65aafff link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-upgrade 65aafff link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-csi 65aafff link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-single-node-upgrade 65aafff link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-agnostic-ovn-cmd 65aafff link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-serial 65aafff link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node 65aafff link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 734b389 into openshift:master Mar 20, 2024
14 of 22 checks passed
@openshift-ci-robot
Copy link

@eggfoobar: Jira Issue OCPBUGS-31074: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31074 has been moved to the MODIFIED state.

In response to this:

added a check for static containers during the cpu affinity comparison between the host and expected value, this is done to account for the fact that static pods do not get altered by the workload webhook and on realtime deployments we might get CPU affinity changes for static pods that do not go through the workload partitioning feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403210141.p0.g734b389.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants