OCPBUGS-24363,SDN-4403: Downstream merge 20240415 #2124
Conversation
control file is used to communicate with the running daemon to modify its properties, whereas sock file is AF_UNIX transport to run OVSDB protocol over Signed-off-by: Girish Moodalbail <gmoodalbail@nvidia.com>
Bump to k8s 1.29.2 in kind, and bumps to go 1.21 Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
serviceCidr is a new v1alpha feature that we do not support yet, so we should skip the tests Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
go mod tidy && go mod vendor && go mod verify framework.expectEqual() was deprecated in favor of gomega.Expect(foo).To(gomega.equal(foo)) dropped vendor dir this time Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
Kube Rebase 1.29
Bumps google.golang.org/protobuf from 1.31.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
control file is not same as sock file
…google.golang.org/protobuf-1.33.0 Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /test/e2e
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0. - [Commits](golang/crypto@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…golang.org/x/crypto-0.17.0 Bump golang.org/x/crypto from 0.16.0 to 0.17.0 in /test/e2e
Fix the case for "all endpoints terminating on a node when traffic policy is local": "When the traffic policy is "Local" and all endpoints are terminating within a single node, then traffic should be routed to any terminating endpoint that is ready on that node." https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/1669-proxy-terminating-endpoints/README.md#example-all-endpoints-terminating-on-a-node-when-traffic-policy-is-local The endpoint selection logic in the services controller is now entirely implemented in getEndpointsForService, which computes for a given service and each service port all its cluster-wide endpoints and per-node local endpoints. We first apply a cluster-wide vs local endpoint selection and only then we apply readiness-based filtering with getEligibleEndpointAddresses. Added unit tests for the new logic. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
this test is flaking and needs to be fixed Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
skip ipv6 'should listen on each host address test'
ricky-rav
force-pushed
the
downstream_merge_20240415
branch
from
ad6eb23
to
bc38bfd
Compare
|
@ricky-rav: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/assign @tssurya |
|
@ricky-rav : do we need to run payload on this one for disruption signals? (I see words services, etp=local and then immediately go payload :) better safe than sorry?) |
|
@ricky-rav: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
1 similar comment
|
@ricky-rav: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload 4.16 ci blocking |
|
@ricky-rav: trigger 5 job(s) of type blocking for the ci release of OCP 4.16
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fae2c1a0-fbd3-11ee-9d4b-d9670853cee6-0 trigger 8 job(s) of type blocking for the nightly release of OCP 4.16
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fae2c1a0-fbd3-11ee-9d4b-d9670853cee6-1 |
|
/lgtm thanks for taking care of this ricky |
|
/approve |
|
/tide refresh |
openshift-ci
bot
added
the
approved
|
/retitle SDN-4403: Downstream merge 20240415 |
|
/tide refresh |
|
/jira refresh |
|
@tssurya: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@ricky-rav: This pull request references SDN-4403 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/tide refresh |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpickard22, ricky-rav, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 50306b3
into
openshift:master
ricky-rav
changed the title
|
@ricky-rav: Jira Issue OCPBUGS-24363 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@ricky-rav: Jira Issue OCPBUGS-24363: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-24363 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-ovn-kubernetes-base-container-v4.16.0-202404162215.p0.g50306b3.assembly.stream.el9 for distgit ovn-kubernetes-base. |
@bpickard22 @JacobTanenbaum PTAL