Merge "use 'exc_info=1' instead of import traceback"

openstack · Aug 5, 2013 · 2380fef · 2380fef
2 parents 851520e + 6d0d9e2
commit 2380fef
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/cinder/volume/manager.py b/cinder/volume/manager.py
@@ -306,8 +306,7 @@ def create_volume(self, context, volume_id, request_spec=None,
                                                             filter_properties)
 
                 if rescheduled:
-                    # log the original build error
-                    self._log_original_error(exc_info)
+                    LOG.error(_('Unexpected Error: '), exc_info=exc_info)
                     msg = (_('Creating %(volume_id)s %(snapshot_id)s '
                              '%(image_id)s was rescheduled due to '
                              '%(reason)s')
@@ -388,11 +387,6 @@ def create_volume(self, context, volume_id, request_spec=None,
         self._notify_about_volume_usage(context, volume_ref, "create.end")
         return volume_ref['id']
 
-    def _log_original_error(self, exc_info):
-        type_, value, tb = exc_info
-        LOG.error(_('Error: %s') %
-                  traceback.format_exception(type_, value, tb))
-
     def _reschedule_or_error(self, context, volume_id, exc_info,
                              snapshot_id, image_id, request_spec,
                              filter_properties):