Fix incorrect tgt-admin call in create_iscsi_target

* Fixes bug 1039826 * Missed one of the execute cmds that was using 'val %s' as args Change-Id: I5e6af737ada1c2bcf7a495710e2b10c8c74bb534
openstack · Aug 23, 2012 · 3034247 · 3034247
1 parent 4e81c90
commit 3034247
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/cinder/volume/iscsi.py b/cinder/volume/iscsi.py
@@ -116,8 +116,9 @@ def create_iscsi_target(self, name, tid, lun, path, **kwargs):
                 f.close()
 
             self._execute('tgt-admin', '--execute',
-                          '--conf %s' % volume_path,
-                          '--update %s' % vol_id, run_as_root=True)
+                          '--conf', volume_path,
+                          '--update', vol_id,
+                          run_as_root=True)
 
         except Exception as ex:
             LOG.exception(ex)