Skip to content

Commit

Permalink
SolidFire API RequestID is useless.
Browse files Browse the repository at this point in the history
The SolidFire API can take an int or a string for a request-id,
when using an int however it needs to actually be a valid int.

The driver currently was doing an int(uuid) which is too large and
as a result get's truncated making it difficult or impossible to track
request-ids.

This patch chanes the generate request-id to form a hash of the uuid so
that it can be tracked.

Fixed bug: 1199198

Change-Id: I38d5e3d189e679678898c329a9fa173a47853d47
  • Loading branch information
j-griffith committed Jul 9, 2013
1 parent e958394 commit 723486b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cinder/volume/drivers/solidfire.py
Expand Up @@ -117,7 +117,7 @@ def _issue_api_request(self, method_name, params):
# can't be re-used
retry_count = 5
while retry_count > 0:
request_id = int(uuid.uuid4()) # just generate a random number
request_id = hash(uuid.uuid4()) # just generate a random number
command = {'method': method_name,
'id': request_id}

Expand Down

0 comments on commit 723486b

Please sign in to comment.