Skip to content

Commit

Permalink
emit warning while running flake8 without virtual env
Browse files Browse the repository at this point in the history
run_tests.sh -N -p
it will call the flake8 installed on your host to detect PEP8, and
the flake8 plugin "OpenStack hacking" may not installed on your
host, so this command may not detect the OpenStack Style Commandment
supplied by hacking(e.g H202).

run_tests.sh -p
it will call the flake8 from virtual env, flake8 plugin "OpenStack
hacking" installed in virtual env will be triggered.

The result from "run_tests.sh -p" should be trusted, and jenkins uses
virtual env to run flake8 too.

When "-N" is enabled, emit warning to remind user.

Bug #1208584

Change-Id: Ie08e5fa2b44088dad135e11583c046650d65df1e
  • Loading branch information
skuicloud committed Aug 21, 2013
1 parent fc705de commit 8619b97
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions run_tests.sh
Expand Up @@ -180,6 +180,10 @@ function copy_subunit_log {

function run_pep8 {
echo "Running flake8 ..."
if [ $never_venv -eq 1 ]; then
echo "**WARNING**:"
echo "Running flake8 without virtual env may miss OpenStack HACKING detection"
fi
bash -c "${wrapper} flake8 cinder* bin/*"
}

Expand Down

0 comments on commit 8619b97

Please sign in to comment.