Skip to content

Commit

Permalink
Merge "Make the SolidFire driver api port configurable."
Browse files Browse the repository at this point in the history
  • Loading branch information
Jenkins authored and openstack-gerrit committed Aug 21, 2013
2 parents 27df5c5 + 299d06f commit d2b48cd
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
10 changes: 7 additions & 3 deletions cinder/volume/drivers/solidfire.py
Expand Up @@ -47,7 +47,12 @@

cfg.StrOpt('sf_account_prefix',
default=socket.gethostname(),
help='Create SolidFire accounts with this prefix'), ]
help='Create SolidFire accounts with this prefix'),

cfg.IntOpt('sf_api_port',
default=443,
help='SolidFire API port. Useful if the device api is behind '
'a proxy on a different port.'), ]


CONF = cfg.CONF
Expand Down Expand Up @@ -105,8 +110,7 @@ def _issue_api_request(self, method_name, params, version='1.0'):
'xMaxSnapshotsPerNodeExceeded',
'xMaxClonesPerNodeExceeded']
host = self.configuration.san_ip
# For now 443 is the only port our server accepts requests on
port = 443
port = self.configuration.sf_api_port

cluster_admin = self.configuration.san_login
cluster_password = self.configuration.san_password
Expand Down
9 changes: 8 additions & 1 deletion etc/cinder/cinder.conf.sample
Expand Up @@ -1266,12 +1266,19 @@
# Options defined in cinder.volume.drivers.solidfire
#

# Set 512 byte emulation on volume creation; (boolean value)
# Set 512 byte emulation on volume creation (boolean value)
#sf_emulate_512=true

# Allow tenants to specify QOS on create (boolean value)
#sf_allow_tenant_qos=false

# Create solidfire accounts with this prefix. Defaults to current
# hostname (string value)
#sf_account_prefix=

# Solidfire API port. Useful if the device is behind a proxy (integer value)
#sf_api_port=443


#
# Options defined in cinder.volume.drivers.storwize_svc
Expand Down

0 comments on commit d2b48cd

Please sign in to comment.