Skip to content

Commit

Permalink
remove unused methods in driver.Scheduler
Browse files Browse the repository at this point in the history
cinder.scheduler.host_manager.HostManager doesn't have get_host_list()
and get_service_capabilities(). But we don't catch the AttributeError
by them. Therefore, get_host_list() and get_service_capabilities() in
cinder.scheduler.driver.Scheduler have not been used.

Also, get_host_list() and get_service_capabilities() in
cinder.scheduler.manager.SchedulerManager have not been used.

Change-Id: I402cf068612866649cc8645391eff38fca56f634
Closes-Bug: #1236723
  • Loading branch information
KIYOHIRO ADACHI committed Oct 8, 2013
1 parent 338c826 commit f330eac
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
9 changes: 0 additions & 9 deletions cinder/scheduler/driver.py
Expand Up @@ -61,15 +61,6 @@ def __init__(self):
CONF.scheduler_host_manager)
self.volume_rpcapi = volume_rpcapi.VolumeAPI()

def get_host_list(self):
"""Get a list of hosts from the HostManager."""
return self.host_manager.get_host_list()

def get_service_capabilities(self):
"""Get the normalized set of capabilities for the services.
"""
return self.host_manager.get_service_capabilities()

def update_service_capabilities(self, service_name, host, capabilities):
"""Process a capability update from a service node."""
self.host_manager.update_service_capabilities(service_name,
Expand Down
8 changes: 0 additions & 8 deletions cinder/scheduler/manager.py
Expand Up @@ -63,14 +63,6 @@ def init_host(self):
ctxt = context.get_admin_context()
self.request_service_capabilities(ctxt)

def get_host_list(self, context):
"""Get a list of hosts from the HostManager."""
return self.driver.get_host_list()

def get_service_capabilities(self, context):
"""Get the normalized set of capabilities for this zone."""
return self.driver.get_service_capabilities()

def update_service_capabilities(self, context, service_name=None,
host=None, capabilities=None, **kwargs):
"""Process a capability update from a service node."""
Expand Down

0 comments on commit f330eac

Please sign in to comment.