Skip to content

Commit

Permalink
Revert "Fix volume_rpcapi calls for chance/simple scheds"
Browse files Browse the repository at this point in the history
This reverts commit d5cd652.

Closes-Bug: #1229867

Change-Id: Iee866ddb08d52642bc36bd6ae82bd0d7283cad8e
  • Loading branch information
dprince committed Sep 24, 2013
1 parent c07a31d commit f4dc301
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
4 changes: 1 addition & 3 deletions cinder/scheduler/chance.py
Expand Up @@ -76,9 +76,7 @@ def schedule_create_volume(self, context, request_spec, filter_properties):

updated_volume = driver.volume_update_db(context, volume_id, host)
self.volume_rpcapi.create_volume(context, updated_volume, host,
allow_reschedule=False,
snapshot_id=snapshot_id,
image_id=image_id)
snapshot_id, image_id)

def host_passes_filters(self, context, host, request_spec,
filter_properties):
Expand Down
14 changes: 7 additions & 7 deletions cinder/scheduler/simple.py
Expand Up @@ -62,10 +62,11 @@ def schedule_create_volume(self, context, request_spec, filter_properties):
if not utils.service_is_up(service):
raise exception.WillNotSchedule(host=host)
updated_volume = driver.volume_update_db(context, volume_id, host)
self.volume_rpcapi.create_volume(context, updated_volume, host,
allow_reschedule=False,
snapshot_id=snapshot_id,
image_id=image_id)
self.volume_rpcapi.create_volume(context,
updated_volume,
host,
snapshot_id,
image_id)
return None

results = db.service_get_all_volume_sorted(elevated)
Expand All @@ -83,9 +84,8 @@ def schedule_create_volume(self, context, request_spec, filter_properties):
self.volume_rpcapi.create_volume(context,
updated_volume,
service['host'],
allow_reschedule=False,
snapshot_id=snapshot_id,
image_id=image_id)
snapshot_id,
image_id)
return None
msg = _("Is the appropriate service running?")
raise exception.NoValidHost(reason=msg)

0 comments on commit f4dc301

Please sign in to comment.