Skip to content

Commit

Permalink
Remove execute permissions from test files.
Browse files Browse the repository at this point in the history
Remove execute permissions from test_volumes.py and
test_storwize_svc.py, which caused the tests defined in them
to be skipped.

Fixing the permissions caused test_create_volume_with_volume_type to
execute, which fails. The cause of the failure is that
(1) LoggingVolumeDriver doesn't implement get_volume_stats(), and
(2) The fake RPC doesn't pass the statistics to the scheduler for
some reason.

Because this test doesn't test the scheduler, just change to use the
simple scheduler and work around the issue.

Change-Id: Ie01331d484c5c48c78b626eff1ad793dbbe7182c
Fixes: bug 1183416
  • Loading branch information
avishay-traeger committed May 29, 2013
1 parent 11b184f commit fa6404e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cinder/tests/integrated/integrated_helpers.py
Expand Up @@ -94,6 +94,10 @@ def _get_flags(self):
# Auto-assign ports to allow concurrent tests
f['osapi_volume_listen_port'] = 0

# Use simple scheduler to avoid complications - we test schedulers
# separately
f['scheduler_driver'] = 'cinder.scheduler.simple.SimpleScheduler'

return f

def get_unused_server_name(self):
Expand Down
Empty file modified cinder/tests/integrated/test_volumes.py 100755 → 100644
Empty file.
Empty file modified cinder/tests/test_storwize_svc.py 100755 → 100644
Empty file.

0 comments on commit fa6404e

Please sign in to comment.