Fix misused assertTrue in unit tests

Refactored unit tests to use assertEqual instead of assertTrue where needed. Fixes bug #1226374 Change-Id: Iac5117c7a8dd3769aa6e303c6830aad291d5a0f7
openstack · Sep 17, 2013 · b040c1a · b040c1a
1 parent 4164949
commit b040c1a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/glance/tests/unit/test_db.py b/glance/tests/unit/test_db.py
@@ -407,7 +407,7 @@ def test_save_image_member(self):
         image_member = self.image_member_repo.get(TENANT2)
         image_member.status = 'accepted'
         image_member_updated = self.image_member_repo.save(image_member)
-        self.assertTrue(image_member.id, image_member_updated.id)
+        self.assertEqual(image_member.id, image_member_updated.id)
         self.assertEqual(image_member_updated.status, 'accepted')
 
     def test_add_image_member(self):

diff --git a/glance/tests/unit/v1/test_registry_api.py b/glance/tests/unit/v1/test_registry_api.py
@@ -420,7 +420,7 @@ def test_get_index_limit(self):
         self.assertEquals(len(images), 1)
 
         # expect list to be sorted by created_at desc
-        self.assertTrue(images[0]['id'], UUID4)
+        self.assertEqual(images[0]['id'], UUID4)
 
     def test_get_index_limit_negative(self):
         """

diff --git a/glance/tests/unit/v2/test_registry_api.py b/glance/tests/unit/v2/test_registry_api.py
@@ -507,7 +507,7 @@ def test_get_index_limit(self):
         self.assertEquals(len(images), 1)
 
         # expect list to be sorted by created_at desc
-        self.assertTrue(images[0]['id'], UUID4)
+        self.assertEqual(images[0]['id'], UUID4)
 
     def test_get_index_limit_marker(self):
         """