Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add tests and simplify GlanceExceptions.
This also fixes some incorrect use of GlanceException parameters. Fixes bug: 1009122 Fixes bug: 1010140 Change-Id: Ic77856686a0259da2318e05b15f3d382508c00b9
- Loading branch information
Showing
9 changed files
with
65 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# vim: tabstop=4 shiftwidth=4 softtabstop=4 | ||
|
||
# Copyright 2012 OpenStack, LLC | ||
# All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
# not use this file except in compliance with the License. You may obtain | ||
# a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
# License for the specific language governing permissions and limitations | ||
# under the License. | ||
|
||
from glance.common import exception | ||
from glance.tests import utils as test_utils | ||
|
||
|
||
class GlanceExceptionTestCase(test_utils.BaseTestCase): | ||
|
||
def test_default_error_msg(self): | ||
class FakeGlanceException(exception.GlanceException): | ||
message = "default message" | ||
|
||
exc = FakeGlanceException() | ||
self.assertEquals(unicode(exc), 'default message') | ||
|
||
def test_specified_error_msg(self): | ||
self.assertTrue('test' in unicode(exception.GlanceException('test'))) | ||
|
||
def test_default_error_msg_with_kwargs(self): | ||
class FakeGlanceException(exception.GlanceException): | ||
message = "default message: %(code)s" | ||
|
||
exc = FakeGlanceException(code=500) | ||
self.assertEquals(unicode(exc), "default message: 500") | ||
|
||
def test_specified_error_msg_with_kwargs(self): | ||
self.assertTrue('test: 500' in | ||
unicode(exception.GlanceException('test: %(code)s', | ||
code=500))) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters